Add ruff format & lint (isort only) #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 89.92% 90.43% +0.50%
==========================================
Files 31 31
Lines 1032 1087 +55
Branches 104 158 +54
==========================================
+ Hits 928 983 +55
Misses 69 69
Partials 35 35 ☔ View full report in Codecov by Sentry. |
Natim
approved these changes
Jul 3, 2024
Natim
reviewed
Jul 3, 2024
Natim
reviewed
Jul 3, 2024
Comment on lines
34
to
+38
| raise ImproperlyConfigured( | ||
| "The CONSTANCE_DATABASE_CACHE_BACKEND setting refers to a " | ||
| 'The CONSTANCE_DATABASE_CACHE_BACKEND setting refers to a ' | ||
| "subclass of Django's local-memory backend (%r). Please " | ||
| "set it to a backend that supports cross-process caching." | ||
| % settings.DATABASE_CACHE_BACKEND) | ||
| 'set it to a backend that supports cross-process caching.' % settings.DATABASE_CACHE_BACKEND | ||
| ) |
There was a problem hiding this comment.
Should we take the opportunity to migrate this to a f-string?
There was a problem hiding this comment.
We should. There are linters for that in ruff. But to reduce complexity of reviewing process I've moved this out of scope of this PR.
There was a problem hiding this comment.
Looks like the start of a great refresh 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All code changes were made by ruff automatically and marked by it as safe